Support Empty Array Annotations in NixIO #806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
property.definitionattribute is used to tag both empty annotations and array annotations. This breaks down in the case of empty array annotations.I moved the array annotation tag to
property.typewhich appeared to be unused as well, and I added a test with an empty array annotation.@achilleas-k is using the
property.typeattribute feasible / does that cause any other issues down the line? It only seems to work withnixio<=1.5.0b3.