Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GraphDynamicsInterop utils usable by outside pacakges #541

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

MasonProtter
Copy link
Contributor

@MasonProtter MasonProtter commented Feb 7, 2025

This PR does a couple of things:

  1. Adds a field to Connector so that it can store a Set of connection_blox. The idea is that these are for holding new blox that only appear in connections, but aren't necessarily blox in and of themselves.
  2. I then made it so that get_bloxs has a method get_bloxs(g, conns) which also fetches the bloxs that were in the conns fields (if any). The reason I had to do it this way is to accomodate the way that composite blox are formed, I couldn't rely on just adding the blox to the graph itself if the graph isn't accessed by Connector, and I also wanted to avoid adding the same itnermediate blox multiple times (sometimes synaptic blox want to re-use a synapse for efficiency purposes)
  3. it reworks some of the GraphDynamics interop stuff to make it usable from other packages who also want to use them (and adds a very basic way to generate connection dispatches from a Connector object

@MasonProtter
Copy link
Contributor Author

I no longer need 1 and 2 so I am removing them from this PR.

@MasonProtter MasonProtter changed the title Rework some interfaces to work with SynapticBlox Make GraphDynamicsInterop utils usable by outside pacakges Feb 20, 2025
@MasonProtter MasonProtter merged commit 77e2ae3 into master Feb 20, 2025
6 checks passed
@MasonProtter MasonProtter deleted the prep-for-synaptic-blox branch February 20, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant