Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily disable peak-detection tests for MetabolicHHNeuron network #544

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

bbantal
Copy link
Contributor

@bbantal bbantal commented Feb 14, 2025

This is a temporary fix that removes a test prone to occasional failure. The solver appears to have some randomness, causing the test to pass at times and fail at others.

I'll come up with a more robust test once I have the time, this is just a bandaid fix for now.

@bbantal bbantal requested a review from MasonProtter February 14, 2025 04:38
@MasonProtter MasonProtter merged commit 11582e6 into master Feb 19, 2025
6 checks passed
@MasonProtter MasonProtter deleted the bba-quick-fix-test branch February 19, 2025 08:39
david-hofmann pushed a commit that referenced this pull request Feb 20, 2025
#544)

* temporarily disable peak-detection tests for MetabolicHHNeuron network

* apply test_skip to broken metabolicHHneuron network tests

Co-authored-by: Mason Protter <[email protected]>

---------

Co-authored-by: Mason Protter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants