Remove the ability to pick up the Fake Star Coin (why was this a thing before)#7
Open
kirbluemodding wants to merge 3 commits into
Open
Remove the ability to pick up the Fake Star Coin (why was this a thing before)#7kirbluemodding wants to merge 3 commits into
kirbluemodding wants to merge 3 commits into
Conversation
… Bear boss For some reason, this boss has ground pound collision behavior that is completely different than the one used for Yoshi, with the cost being that it... doesn't really work properly at all. This issue can be replicated in likely every single mod that didn't modify this file, and it's almost a little surprising that nobody's noticed this. If you're too lazy to test the code out yourself, I've made a little video demonstrating what happens and what the fix looks like: https://youtu.be/qrK5n1ScwHw
…he Fuzzy Bear boss" This reverts commit acc4505.
In NewerSMBW, you can pick up fake star coins similar to how one picks up a player or POW block. However, not only is this obviously unintended, but the feature doesn't even work (you just pick up/throw air)! How disappointing... All jokes aside, this has probably leaked its way into every major mod I can think of that uses this sprite, so it'd probably be good to fix it before we taint the future generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copied from the most recent commit in this pull request, in case github somehow refuses to show it:
"In NewerSMBW, you can pick up fake star coins similar to how one picks up a player or POW block. However, not only is this obviously unintended, but the feature doesn't even work (you just pick up/throw air)! How disappointing...
All jokes aside, this has probably leaked its way into every major mod I can think of that uses this sprite, so it'd probably be good to fix it before we taint the future generation."