feat: 오픈 예정 지역 칩 클릭 시 토스트 안내 추가#171
Merged
Merged
Conversation
disabled 상태를 제거하고 클릭 핸들러에서 isPendingRegion을 분기해 '곧 추가될 지역입니다. 조금만 기다려주세요!' 토스트를 노출 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트는 RegionChip.tsx에서 대기 중인 지역(pending region)일 때 칩을 비활성화하는 대신, 클릭 시 경고 토스트 메시지를 표시하도록 변경합니다. 리뷰 피드백에서는 disabled 속성이 제거됨에 따라 스크린 리더 사용자가 비활성화 상태를 인지할 수 있도록 aria-disabled 속성을 추가하여 웹 접근성을 개선할 것을 제안하고 있습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
disabled 제거 후 스크린 리더가 비활성 상태를 인지하지 못하는 문제를 aria-disabled 속성으로 보완 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 PR 제목
feat: 오픈 예정 지역 칩 클릭 시 토스트 안내 추가
📑 작업 상세 내역
disabled처리를 제거하고 클릭 핸들러에서 분기 처리합니다 (disabled 버튼은 클릭 이벤트가 발화되지 않음)🙏 리뷰 요청 사항
📃 참고 자료
src/pageComponents/gathering/create/RegionChip.tsx🖼️ 작업 결과물