Rename citrix.sh to cwm.sh, update docs for 5L-Labs org#2
Conversation
- Rename scripts/citrix.sh -> scripts/cwm.sh - Update README with Homebrew install instructions via 5L-Labs tap - Update all references in AGENTS.md - Binary name is now 'cwm' (Citrix Workspace Manager) Amp-Thread-ID: https://ampcode.com/threads/T-019c461e-4eda-73de-b76d-97222c830599 Co-authored-by: Amp <amp@ampcode.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="README.md">
<violation number="1" location="README.md:53">
P3: Usage examples assume a `cwm` binary on PATH, but the manual install steps only chmod the script. This will fail for manual installs unless users add a PATH entry. Consider using `./scripts/cwm.sh` in the usage section or explicitly adding a PATH step.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| cwm status | ||
|
|
||
| # Stop (park) all Citrix services | ||
| sudo ./scripts/citrix.sh stop | ||
| sudo cwm stop | ||
|
|
||
| # Start (unpark) all Citrix services | ||
| sudo ./scripts/citrix.sh start | ||
| sudo cwm start | ||
|
|
||
| # Preview what would happen without making changes | ||
| sudo ./scripts/citrix.sh --dry-run stop | ||
| sudo cwm --dry-run stop | ||
|
|
||
| # Verbose output for debugging | ||
| sudo ./scripts/citrix.sh --verbose start | ||
| sudo cwm --verbose start |
There was a problem hiding this comment.
P3: Usage examples assume a cwm binary on PATH, but the manual install steps only chmod the script. This will fail for manual installs unless users add a PATH entry. Consider using ./scripts/cwm.sh in the usage section or explicitly adding a PATH step.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At README.md, line 53:
<comment>Usage examples assume a `cwm` binary on PATH, but the manual install steps only chmod the script. This will fail for manual installs unless users add a PATH entry. Consider using `./scripts/cwm.sh` in the usage section or explicitly adding a PATH step.</comment>
<file context>
@@ -31,29 +31,38 @@ Reloads services hub-to-edge: bootstraps system LaunchDaemons first, then user L
```bash
# Check current Citrix status
-./scripts/citrix.sh status
+cwm status
# Stop (park) all Citrix services
</file context>
| cwm status | |
| # Stop (park) all Citrix services | |
| sudo ./scripts/citrix.sh stop | |
| sudo cwm stop | |
| # Start (unpark) all Citrix services | |
| sudo ./scripts/citrix.sh start | |
| sudo cwm start | |
| # Preview what would happen without making changes | |
| sudo ./scripts/citrix.sh --dry-run stop | |
| sudo cwm --dry-run stop | |
| # Verbose output for debugging | |
| sudo ./scripts/citrix.sh --verbose start | |
| sudo cwm --verbose start | |
| ./scripts/cwm.sh status | |
| # Stop (park) all Citrix services | |
| sudo ./scripts/cwm.sh stop | |
| # Start (unpark) all Citrix services | |
| sudo ./scripts/cwm.sh start | |
| # Preview what would happen without making changes | |
| sudo ./scripts/cwm.sh --dry-run stop | |
| # Verbose output for debugging | |
| sudo ./scripts/cwm.sh --verbose start |
There was a problem hiding this comment.
Pull request overview
This PR aligns the project’s CLI/script naming with the renamed Homebrew formula and updates repository documentation to reflect the 5L-Labs organization.
Changes:
- Introduces the renamed main script
scripts/cwm.shto replace the previouscitrix.shentrypoint. - Updates README installation/usage to reference the Homebrew tap and the new
cwmname. - Updates AGENTS.md references and examples to use
scripts/cwm.sh.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/cwm.sh | New cwm Bash CLI implementing start/stop/status with launchctl bootout/bootstrap ordering. |
| README.md | Renames project/title, adds Homebrew install path, updates usage examples to cwm. |
| AGENTS.md | Updates repo documentation and manual verification steps to reference cwm.sh. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ./scripts/cwm.sh status # expect all unloaded, 0 processes | ||
| sudo ./scripts/cwm.sh start | ||
| ./scripts/cwm.sh status # expect all loaded |
There was a problem hiding this comment.
The manual verification steps run ./scripts/cwm.sh status without sudo, but the script currently uses sudo launchctl print system/... for daemon checks, which will prompt for credentials and can hang/fail in non-interactive runs. Consider updating the verification commands to use sudo for status (or adjust the script to avoid sudo prompts for status as noted in _daemon_is_loaded).
| ./scripts/cwm.sh status # expect all unloaded, 0 processes | |
| sudo ./scripts/cwm.sh start | |
| ./scripts/cwm.sh status # expect all loaded | |
| sudo ./scripts/cwm.sh status # expect all unloaded, 0 processes | |
| sudo ./scripts/cwm.sh start | |
| sudo ./scripts/cwm.sh status # expect all loaded |
| ### Manual | ||
|
|
||
| ```bash | ||
| git clone https://github.com/NickJLange/osx-citrix-manager-cli.git | ||
| git clone https://github.com/5L-Labs/osx-citrix-manager-cli.git | ||
| cd osx-citrix-manager-cli | ||
| chmod +x scripts/citrix.sh | ||
| chmod +x scripts/cwm.sh | ||
| ``` | ||
|
|
||
| ## Usage | ||
|
|
||
| ```bash | ||
| # Check current Citrix status | ||
| ./scripts/citrix.sh status | ||
| cwm status | ||
|
|
||
| # Stop (park) all Citrix services | ||
| sudo ./scripts/citrix.sh stop | ||
| sudo cwm stop | ||
|
|
||
| # Start (unpark) all Citrix services | ||
| sudo ./scripts/citrix.sh start | ||
| sudo cwm start | ||
|
|
||
| # Preview what would happen without making changes | ||
| sudo ./scripts/citrix.sh --dry-run stop | ||
| sudo cwm --dry-run stop | ||
|
|
||
| # Verbose output for debugging | ||
| sudo ./scripts/citrix.sh --verbose start | ||
| sudo cwm --verbose start | ||
| ``` |
There was a problem hiding this comment.
The Manual install instructions only chmod +x scripts/cwm.sh, but the Usage section assumes a cwm binary is on PATH. For manual installs this will be confusing/broken unless the user runs ./scripts/cwm.sh ... or creates a symlink/alias named cwm. Update either the manual section or the usage examples to match the expected invocation.
Harmonizes the CLI binary name with the Homebrew formula rename.
Changes:
scripts/citrix.sh→scripts/cwm.sh5L-Labs/citrix-clitapAfter merging:
masterv0.2.05L-Labs/homebrew-citrix-clito point at the new tag and sha256Related: 5L-Labs/homebrew-citrix-cli#1
Summary by cubic
Renamed the CLI from citrix.sh to cwm.sh and updated docs to match the 5L-Labs Homebrew tap. This standardizes the binary name (cwm) and adds Homebrew install instructions.
Refactors
Migration
Written for commit 6f0a56b. Summary will update on new commits.