Standards hardening: typeDiagram models, PR auto-merge/own-PR, strict protection + website/CI updates#16
Merged
Merged
Conversation
Detect whether a PR touches anything outside website/**; the heavy F#/Playwright dashboard suite now runs only when it does. A new always-running "Test" gate (the required status check) passes when the dashboard tests pass or are legitimately skipped, so website-only PRs stay fast and mergeable while code PRs still gate on real tests. Also track templates/.claude/settings.local.json (the canonical artifact referenced by the spec and skill; it was hidden by a global ~/.config/git/ignore rule).
…trict protection, Deslop consistency - Spec [MODEL-TYPEDIAGRAM]: data models MUST be generated from typeDiagram, never hand-written; codegen wired into `make build`; file an issue if typeDiagram can't express a case. Mirrored as a universal Hard Rule in templates/AGENTS.md + checklist. - Spec [BRANCH-AGENT] + templates/AGENTS.md: agents OWN every PR until green — enable auto-merge, monitor, fix-and-push until checks pass; never hand back red/running. - submit-pr skill: enable auto-merge (`gh pr merge --auto --squash`); prominent git- exception callout (git allowed only for PR submit/monitor; never co-author). - code-dedup skill: bare `deslop .` (reads .deslop.toml) is the CI gate — dropped the contradictory hardcoded `--fail-over 5.0` "CI gate" line ([CI-DESLOP]). - common-repo-settings: mandate strict required status checks + allow_update_branch; branch-protection ruleset is repaired in place (existence is not conformance). - ci.yml: correct stale Playwright version comment (1.58.2 -> 1.60.0). - templates/AGENTS.md: trim redundant fluff.
MelbourneDeveloper
enabled auto-merge (squash)
June 17, 2026 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Hardens the portfolio standards (typeDiagram data models, PR auto-merge + own-PR-until-green, strict branch protection, Deslop CI-gate consistency) and ships the accompanying website/CI/template updates.
What Was Added?
[MODEL-TYPEDIAGRAM](docs/specs/REPO-STANDARDS-SPEC.md) — data models MUST be generated from typeDiagram, never hand-written; codegen wired intomake build; file a typeDiagram issue when it can't express a case. Mirrored as a universal Hard Rule intemplates/AGENTS.mdand the assessment checklist.[BRANCH-AGENT]andtemplates/AGENTS.md— agents enable auto-merge, monitor, and fix-and-push until checks pass; never hand back a red/running PR.gh pr merge --auto --squash) and a prominent git-exception callout (git allowed only for PR submit/monitor; never co-author).templates/.github/common-repo-settings.md— mandatestrict_required_status_checks_policy+allow_update_branch; ruleset is repaired in place (existence is not conformance).templates/website/release.js,releases.njk) and CodeQL/release template refinements.What Was Changed or Deleted?
deslop .(reads.deslop.toml) is the CI gate; removed the contradictory hardcoded--fail-over 5.0"CI gate" line.ci.yml— corrected stale Playwright version comment (1.58.2 → 1.60.0); website-only PRs skip dashboard tests via a change-detection gate.templates/AGENTS.md— trimmed redundant fluff for higher signal density.index,features,get-started,how-it-works, base layout, site data).How Do The Automated Tests Prove It Works?
CI runs
make test(F# fixture/integration tests that generate the dashboard HTML, then Playwright E2E against it) in the Microsoft Playwright container. This PR touches non-website files, so the change-detection job markscode=trueand the fulldashboard-testsjob runs. No dashboard F# code (repo-report.fsx) or its tests changed, so a greendashboard-testsrun demonstrates the standards/website/template edits introduce no regression. Thesecurityjob (dependency review) also runs.Spec / Doc Changes
docs/specs/REPO-STANDARDS-SPEC.md: new[MODEL-TYPEDIAGRAM],[BRANCH-AGENT]own-PR rule, Deslop CI-gate consistency, two new checklist items.agent-pmo-skill/templates/AGENTS.md,agent-pmo-skill/SKILL.md,AGENTS.md,README.md,dashboard/README.md: standards/instruction updates.agent-pmo-skill/templates/skills/{submit-pr,code-dedup}/SKILL.md,common-repo-settings.md: see above.Breaking Changes