Pin @types/vscode to match engines.vscode (fix VSIX packaging)#58
Merged
Conversation
vsce package rejects a release when @types/vscode (^1.125.0, bumped by a dependency update) is newer than engines.vscode (^1.99.0). The extension only uses the 1.99-era API, so pin @types/vscode back to ^1.99.0 to match the declared engine floor — restoring the v0.11.0 configuration that packaged cleanly. Verified: vscode typecheck passes and `vsce package` succeeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.12.0 Release passed the CodeQL gate and published
typediagram-core@0.12.0andtypediagram@0.12.0to npm, but thePackage VSIXstep failed:@types/vscodewas bumped to^1.125.0(dependency update) whileengines.vscodestayed^1.99.0;vsce packagerejects that mismatch. The extension only uses the 1.99-era API, so this pins@types/vscodeback to^1.99.0— matching the engine floor and restoring the v0.11.0 config that packaged cleanly.Verified locally:
vscodetypecheck passes andvsce packagesucceeds (18 files, ~1 MB VSIX).npm publishes are idempotent (already live); after merge I'll re-point
v0.12.0and the re-run completes VSIX + Marketplace + GitHub Release.🤖 Generated with Claude Code