Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

meihu-ganesh
Copy link

Your checklist for this pull request

  • I have committed only those files that are required.
  • I have tried to make commit messages concise and reflective of the code committed.
  • I have used a branch name reflective of the issue.
  • If there is a relevant issue for the PR, I have used closes #<issue number> to auto-close the issue once PR is merged.

Detailed description

  • In the Issue Addition not working , inside addition.py file there was a small bug where multiplication is used instead of addition.
  • in the issue Greatest Common Divisor Not working , inside gcd.py file a package math is imported and direct gcd function is used from the package.
  • in the issue Simple Interest Calculator gives wrong output , inside simple_interest.py file the formula used was wrong in the line 7 due to missing of '/100' for the value obtained.

Test plan (required)

#1 Addition not working after resolving issue:
image

#2 Greatest Common Divisor Not working after resolving issue:
image

#3 Simple Interest Calculator gives wrong output after resolving issue:
image

Closing issues

closes #1 #2 #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition not working
1 participant