Skip to content

Conversation

@Nityanand13
Copy link
Owner

No description provided.

@Nityanand13 Nityanand13 self-assigned this Aug 20, 2022
@sooraj-shukla
Copy link

Remove the starter code added by create-react-app.

@sooraj-shukla
Copy link

sooraj-shukla commented Aug 20, 2022

Update favicon (use github icon) and app-title (for example - Github Viewer) (Refactor the public folder)
react-app-rampup

@sooraj-shukla
Copy link

Add .nvmrc

@sooraj-shukla
Copy link

sooraj-shukla commented Aug 20, 2022

Remove eslintConfig from package.json and add it in .eslintrc file. Add .eslintignore file as well.

@sooraj-shukla
Copy link

Remove browserslist from package.json file, add .browserslistrc file, explore why this is used.

@sooraj-shukla
Copy link

Add folder structure.

src
    ├── assets
    ├── components
    ├── constants
    ├── containers
    ├── pages
    ├── routes
    ├── services
    ├── store
    │   ├── actions
    │   ├── reducers
    │   └── index.ts
    ├── styles
    │   └── sass 7-1 folder structure here
    ├── types
    ├── utils
    └── App.tsx

You can add .gitkeep to commit and push empty directories/folders.

@sooraj-shukla
Copy link

sooraj-shukla commented Aug 20, 2022

Update Readme, add instruction how to run the app.

# Getting Started with Create React App

This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app).
# Getting Started with React Rampup

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add all the steps one has to do to run the project.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added


</header>
</div>
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still can't see the folder structure mentioned in the comment - #2 (comment).

@@ -0,0 +1,6 @@
{
"extends": [
"react-app",
Copy link

@sooraj-shukla sooraj-shukla Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the following rules as well-

"extends": [
    "react-app",
    "react-app/jest",
    "plugin:react/recommended",
    "airbnb",
    "plugin:import/typescript",
    "plugin:@typescript-eslint/recommended"
  ],
  "parser": "@typescript-eslint/parser",
  "parserOptions": {
    "ecmaFeatures": {
      "jsx": true
    },
    "ecmaVersion": 12,
    "sourceType": "module"
  },
  "plugins": ["react", "@typescript-eslint"]

package.json Outdated
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject"
Copy link

@sooraj-shukla sooraj-shukla Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After modifying the .eslintrc.json, add the following script and try to run it once, and see if there isn't any error -

"lint": "eslint '**/*.ts' '**/*.tsx' '**/*.js'"

@sooraj-shukla sooraj-shukla mentioned this pull request Sep 23, 2022
@sooraj-shukla
Copy link

sooraj-shukla commented Sep 23, 2022

Styles folder structure should be like this.

styles
├── base
├── components
├── pages
 main.scss

@sooraj-shukla
Copy link

Please see the folder structure again -

It is

styles
├── base
├── components
├── pages
 main.scss

NOT

styles
├── main.scss
sass
   ├── base
   ├── components
   ├── pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants