-
Notifications
You must be signed in to change notification settings - Fork 0
Base setup for react rampup #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Remove the starter code added by create-react-app. |
|
Add .nvmrc |
|
Remove |
|
Remove |
|
Add folder structure. You can add |
|
Update Readme, add instruction how to run the app. |
| # Getting Started with Create React App | ||
|
|
||
| This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). | ||
| # Getting Started with React Rampup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add all the steps one has to do to run the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
|
|
||
| </header> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still can't see the folder structure mentioned in the comment - #2 (comment).
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "extends": [ | |||
| "react-app", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the following rules as well-
"extends": [
"react-app",
"react-app/jest",
"plugin:react/recommended",
"airbnb",
"plugin:import/typescript",
"plugin:@typescript-eslint/recommended"
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaFeatures": {
"jsx": true
},
"ecmaVersion": 12,
"sourceType": "module"
},
"plugins": ["react", "@typescript-eslint"]
package.json
Outdated
| "start": "react-scripts start", | ||
| "build": "react-scripts build", | ||
| "test": "react-scripts test", | ||
| "eject": "react-scripts eject" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After modifying the .eslintrc.json, add the following script and try to run it once, and see if there isn't any error -
"lint": "eslint '**/*.ts' '**/*.tsx' '**/*.js'"
|
Styles folder structure should be like this. |
|
Please see the folder structure again - It is NOT |

No description provided.