-
-
Notifications
You must be signed in to change notification settings - Fork 12
New release workflow #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arianvp
wants to merge
43
commits into
main
Choose a base branch
from
new-release-workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New release workflow #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec93a9a
to
ac17880
Compare
I might want to build the sigstore stuff into the upload-ami Python code directly instead using make this not GitHub specific. But that's future work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of downloading the image from hydra we build the image in GitHub Actions.
This is part of the initiative to get rid of
closureInfo
like jobs from hydra to reduce pressure in the nixos cache growth. As images store redundant information and take up a lot of wasted space.All the dependencies of the image should already be cached by hydra so the only thing this build does is assemble the image.
We also attest SLSA build provenance using GitHub Attestations / sigstore using https://github.com/marketplace/actions/attest-build-provenance that records when the image was built and by which GitHub actions workflow.
In the future we want to use https://GitHub.com/arianvp/nix-attest to record nix-specific provenance info but that is blocked on actions/attest#195
We then upload the built image to all AWS regions and sign another attestation linking the image to the image IDs for each region. So that there is a cryptographic statement about which AMIs are official (the AMI namespace is public and open. So anyone can upload any AMI under any name. So we want some statement that these are our AMIs).