make parsed license to be less like tobe a stringy license #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sternenseemann
requested changes
Oct 18, 2025
cabal2nix/src/Distribution/Nixpkgs/Haskell/FromCabal/License.hs
Outdated
Show resolved
Hide resolved
|
|
||
| fromCabalLicense :: Distribution.License.License -> Distribution.Nixpkgs.License.License | ||
| fromCabalLicense (GPL Nothing) = Unknown (Just "GPL") | ||
| fromCabalLicense (GPL Nothing) = Known "lib.licenses.gpl2Plus" |
There was a problem hiding this comment.
These cases are intentional as there is not enough information to conclude what variant of the license in question is used.
There was a problem hiding this comment.
I do realize they were intentional, but they can't stay in their current form. I'm currently working towards disallowing stringy licenses in nixpkgs, and those are pretty much the only ones left. Other options would be to make it even less informational with lib.licenses.free or to add a new custom license (not really a fan of this).
cabal2nix/src/Distribution/Nixpkgs/Haskell/FromCabal/License.hs
Outdated
Show resolved
Hide resolved
cabal2nix/src/Distribution/Nixpkgs/Haskell/FromCabal/License.hs
Outdated
Show resolved
Hide resolved
Hackage requires open source licenses so this should always be a free license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on removing all stringy licenses in nixpkgs, and currently the only ones left are the ones in haskellPackages and node2nix packages. This change fixes the ones for Haskell packages.