Add inputs.self.submodules flake attribute
#12421
Merged
+222
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future-proofing for when 'nix flake metadata' won't return a store path anymore.
This prepares lazy access to flake.nix etc.
This allows a flake to specify that it needs Git submodules to be enabled (or disabled, if we ever change the default) on the top-level flake. This requires the input to be refetched, but since the first fetch is lazy, this shouldn't be expensive. Currently the only attribute allowed by `inputs.self` is `submodules`, but more can be added in the future (e.g. a `lazy` attribute to opt in to lazy tree behaviour). Fixes NixOS#5312, NixOS#9842.
github-actions
bot
added
new-cli
This was referenced Feb 6, 2025
Luflosi
added a commit
to Luflosi/Bachelor-Thesis
that referenced
this pull request
Feb 7, 2025
Nix (with flakes) has an annoying behaviour where a Git subproject won't automatically be available, so a workaround is required. See NixOS/nix#5284 and NixOS/nix#12421.
roberth
reviewed
Feb 10, 2025
This was referenced Feb 13, 2025
Merged
|
Fixes: #7862 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This allows a flake to specify that it needs Git submodules to be enabled (or disabled, if we ever change the default) on the top-level flake. This requires the input to be refetched, but since the first fetch is lazy, this shouldn't be expensive.
Currently the only attribute allowed by
inputs.selfissubmodules, but more can be added in the future (e.g. alazyattribute to opt in to lazy tree behaviour).Fixes #5312, #9842.
TODO: add docs, release note.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.