Rename to "content-address*ing* derivation" #12441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"content-address*ed*" derivation is misleading because all derivations are *themselves* content-addressed. What may or may not be content-addressed is not derivation itself, but the *output* of the derivation. The outputs are not *part* of the derivation (for then the derivation wouldn't be complete before we built it) but rather separate entities produced by the derivation. "content-adddress*ed*" is not correctly because it can only describe what the derivation *is*, and that is not what we are trying to do. "content-address*ing*" is correct because it describes what the derivation *does* --- it produces content-addressed data.
Ericson2314
requested review from
fricklerhandwerk and
edolstra
as code owners
github-actions
bot
added
documentation
with-tests
fricklerhandwerk
approved these changes
Feb 10, 2025
|
I agree with this level of pedantry. |
|
Thanks! I should also note that this is not a new idea out of the blue, in many comments and what-not I have already taken to calling them this. This PR is just a final sed to catch remaining usages of the old terminology. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"content-addressed" derivation is misleading because all derivations are themselves content-addressed. What may or may not be content-addressed is not derivation itself, but the output of the derivation.
The outputs are not part of the derivation (for then the derivation wouldn't be complete before we built it) but rather separate entities produced by the derivation.
"content-adddressed" is not correctly because it can only describe what the derivation is, and that is not what we are trying to do.
"content-addressing" is correct because it describes what the derivation does --- it produces content-addressed data.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.