Some storeFS and similar cleanup
#14080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to tell when it is isued.
This will become useful.
It was getting very hard to follow.
github-actions
bot
added
new-cli
Ericson2314
commented
Sep 25, 2025
Comment on lines
+493
to
+494
| * Only for restrict eval: pure eval just whitelist store paths, | ||
| * never arbitrary paths. |
There was a problem hiding this comment.
The implementation doesn't yet enforce this, but I think this does track for the one place this is in fact used now.
Ericson2314
commented
Sep 25, 2025
Comment on lines
+180
to
+181
| state.allowPath(state.store->followLinksToStorePath(profile.string())); | ||
| state.allowPath(state.store->followLinksToStorePath((profile / "manifest.nix").string())); |
There was a problem hiding this comment.
I don't want to whitelist just part of a store object, that feels weird. Now this does whole store objects.
Mic92
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A few small things I think would be useful to land right away, including a little bit of #14050.
Context
Thinking about #14050 and trying to get rid of the store-wide accessor.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.