fix(libstore/build/derivation-goal): don't assert on partially valid outputs #14137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes: #14130 (maybe?)
Context
Claude-aided debugging:
out
anddev
)out
) is already valid in the storedev
) is NOT validout
)DerivationGoal
cannot return early—it must proceed with the buildDerivationGoal
delegates toDerivationBuildingGoal
to rebuild the entire derivationregisterOutputs()
(derivation-builder.cc:1383-1388), already-valid outputs are skipped to avoid unnecessary re-registrationwantedOutput
(out
) is skipped, so it's NOT added tobuiltOutputs
DerivationGoal
, the code tries to filterbuiltOutputs
to only containwantedOutput
wantedOutput
is not inbuiltOutputs
I'm still trying to write a reproducer to validate...
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.