clang-tidy fix for src/libstore/build/derivation-check.cc

[fzakaria]

Motivation

Let's get clang-tidy to be clean!

> clang-tidy src/libstore/build/derivation-check.cc -p build
>  echo $status
0

Context

../src/libstore/build/derivation-check.cc:85:35: warning: Dereference of undefined pointer value [clang-analyzer-core.NullDereference]
   85 |             if (checks.maxSize && info.narSize > *checks.maxSize)
../src/libstore/build/derivation-check.cc:117:31: warning: 4th function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
  117 |                         throw BuildError(
../src/libstore/build/derivation-check.cc:181:45: warning: 2nd function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
  181 |                     if (auto outputChecks = get(checksPerOutput, outputName))

I'm not sure why but moving away from the destructing let clang-tidy follow the initialization properly.

---

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.