libstore-c: add nix_store_get_fs_closure #14025 with tests and realise error fix #14254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
changed the title
roberth
changed the title
|
That test failure on macOS was a bit of a rabbit hole due to the pre-existing broken error handling in |
…uterGuy/feat/expose-computefsclosure
| // The closure should contain the derivation and its outputs | ||
| ASSERT_GE(closure_paths.size(), 2); | ||
|
|
||
| // Verify the output path is in the closure |
There was a problem hiding this comment.
Would it be good to also verify the paths it returns are the paths we expected to see? I'm not sure if the store paths get returned in a reproducible order. If it does, then we probably should add that check.
4 tasks
RossComputerGuy
approved these changes
Oct 16, 2025
Ericson2314
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Can't push to PR branch.
Context
Includes
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.