Skip to content

Rewriting to use boto3 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Rewriting to use boto3 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
55e38b1
Initial fixes.
takeda Sep 12, 2019
9402b67
Mypy fixes
takeda Jul 23, 2019
14c8684
Optimizing imports
takeda Jul 23, 2019
3cf94f2
Fixing a bug that I introduced
takeda Jul 23, 2019
de9d500
Fixed taking backups.
takeda Jul 25, 2019
f121437
show-console-output works now.
takeda Jul 26, 2019
ca0f025
Fixed check command.
takeda Jul 28, 2019
2843013
Reverted changes that required changes on nixos core as well.
takeda Sep 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions nix/ec2-keypair.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ with lib;
description = "AWS region.";
};

profile = mkOption {
type = types.str;
description = "Name of the profile.";
};

accessKeyId = mkOption {
default = "";
type = types.str;
Expand Down
11 changes: 11 additions & 0 deletions nix/ec2.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,17 @@ in

options = {

deployment.ec2.profile = mkOption {
default = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value should be either an empty string or just "default" but not null value

error: The option value deployment.ec2.profile' in /nix/store/ydszllb0yml02kzi8m4l5sp5mk6z0h3i-nixops-aws-1.7pre0_abcdef/share/nix/nixops-aws/ec2.nix' is not of type string'.
`

example = "dev-Administrator";
type = types.str;
description = ''
The profile name as defined in <filename>~/.aws/config</filename>
If left empty it will be left to boto to decide, which means it will
check <envvar>AWS_PROFILE</envvar> and use "default".
'';
};

deployment.ec2.accessKeyId = mkOption {
default = "";
example = "AKIABOGUSACCESSKEY";
Expand Down
Loading