Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.invocations: init at 2.6.0 #165911

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

samuela
Copy link
Member

@samuela samuela commented Mar 27, 2022

Description of changes

Add invocations and its dependency releases.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@samuela samuela requested review from FRidh and jonringer as code owners March 27, 2022 04:47
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 27, 2022
@samuela
Copy link
Member Author

samuela commented Mar 27, 2022

Re the test suite for releases: Yeah, it appears that they do have a tests/ directory, but I'm not able to get it to run the tests in any conventional way. There's a bug report for this upstream here: bitprophet/releases#95.

I opened an issue for the invocations test suite here: pyinvoke/invocations#29. It appears to be bc the pytest version in nixpkgs is too recent for invocations, but they also don't specify any version constraints in the dev requirements here: https://github.com/pyinvoke/invocations/blob/main/dev-requirements.txt. And I wasn't able to find any other versions of pytest in nixpkgs to try running on.

For posterity's sake here's my attempt at getting the invocations test suite to run:

  checkInputs = [ invoke mock pytest pytest-relaxed ];
  # See https://github.com/pyinvoke/invocations/issues/25 and https://github.com/pyinvoke/invocations/issues/29.
  checkPhase = ''
    inv test
    inv integration
  '';

@samuela samuela force-pushed the samuela/invocations branch from 32b2829 to 5e7bced Compare March 27, 2022 20:40
@samuela
Copy link
Member Author

samuela commented Mar 27, 2022

Addressed comments in 82761fb and 5e7bced.

@samuela
Copy link
Member Author

samuela commented Mar 28, 2022

Ok, I believe I've addressed all the comments now. I'll go ahead and merge tomorrow unless anyone objects.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 165911 run on x86_64-linux 1

4 packages built:
  • python310Packages.invocations
  • python310Packages.releases
  • python39Packages.invocations
  • python39Packages.releases

@SuperSandro2000 SuperSandro2000 merged commit 2c909d2 into NixOS:master Mar 28, 2022
@samuela samuela deleted the samuela/invocations branch March 28, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants