Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directx-shader-compiler: build with gcc11 for i686 #216796

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

andresilva
Copy link
Member

@andresilva andresilva commented Feb 17, 2023

Description of changes

Fixes #216294.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Feb 17, 2023
@SFrijters
Copy link
Member

Result of nixpkgs-review pr 216796 run on x86_64-linux 1

1 package built:
  • driversi686Linux.amdvlk

1 similar comment
@eboskma
Copy link
Contributor

eboskma commented Feb 18, 2023

Result of nixpkgs-review pr 216796 run on x86_64-linux 1

1 package built:
  • driversi686Linux.amdvlk

@andresilva andresilva requested a review from Flakebi February 19, 2023 17:43
@vcunat
Copy link
Member

vcunat commented Feb 20, 2023

That's a different package than in the referenced issue, but possibly same problem and workaround. (I'm sorry)

It's good to check if things work in practice, as mixing compiler versions can cause issues (e.g. with C++ stuff), especially when /run/opengl-driver/* gets injected impurely.

@andresilva
Copy link
Member Author

Tested by running vkcube from pkgsi686Linux.vulkan-tools, no issues. I'm not an expert on any of this though.

@vcunat vcunat merged commit dde4603 into NixOS:master Feb 20, 2023
@vcunat
Copy link
Member

vcunat commented Feb 20, 2023

OK, even if this weren't a complete fix, it sounds better than failing to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: amdvlk
4 participants