Skip to content

rustc: 1.68.2 -> 1.69.0 #226801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zowoq merged 1 commit into from
Apr 23, 2023
Merged

rustc: 1.68.2 -> 1.69.0 #226801

zowoq merged 1 commit into from
Apr 23, 2023

Conversation

@lblasc
Copy link
Contributor

@lblasc lblasc commented Apr 18, 2023 •
edited
Loading

Description of changes

Pre-release draft, release will happen on 20.04.2023.

https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1690-2023-04-20
https://blog.rust-lang.org/2023/04/20/Rust-1.69.0.html

Tested fd and vector on x86_64-linux both are building fine, looks like rust-lang/rust#107688
is included in this release.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Apr 18, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Apr 18, 2023
@zowoq
Copy link
Contributor

zowoq commented Apr 18, 2023

pkgs/development/compilers/rust/1_68.nix needs to be removed.

@lblasc
Copy link
Contributor Author

lblasc commented Apr 18, 2023

thx @zowoq , pkgs/development/compilers/rust/1_68.nix is removed now.

@lblasc
Copy link
Contributor Author

lblasc commented Apr 19, 2023

Built firefox, fd and vector on x86_64-linux.

@lblasc lblasc marked this pull request as ready for review April 21, 2023 04:33
@zowoq
Copy link
Contributor

zowoq commented Apr 21, 2023

Built passthru.tests on x86_64-darwin.

@zowoq zowoq merged commit 081c90f into NixOS:staging Apr 23, 2023
@lblasc lblasc deleted the rust169 branch April 23, 2023 06:39
@trofi
Copy link
Contributor

trofi commented Apr 23, 2023

Bisect claims 081c90f rustc: 1.68.2 -> 1.69.0 broke evcxr in staging:

$ nix build -f. evcxr -L
...
failures:

---- check_for_errors stdout ----
thread 'check_for_errors' panicked at 'assertion failed: `(left == right)`
  left: `[]`,
 right: `["warning 1:15-1:20"]`', evcxr/tests/integration_tests.rs:962:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    check_for_errors

test result: FAILED. 36 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 260.67s

error: test failed, to rerun pass `-p evcxr --test integration_tests`

@trofi
Copy link
Contributor

trofi commented May 4, 2023

Filed bug upstream as evcxr/evcxr#294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@globin globin Awaiting requested review from globin

@winterqt winterqt Awaiting requested review from winterqt

@tjni tjni Awaiting requested review from tjni

@figsoda figsoda Awaiting requested review from figsoda

@cstrahan cstrahan Awaiting requested review from cstrahan

@zowoq zowoq Awaiting requested review from zowoq

Assignees

No one assigned

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lblasc @zowoq @trofi