-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rtaudio: 5.2.0 -> 6.0.1 #245075
rtaudio: 5.2.0 -> 6.0.1 #245075
Conversation
eb90a51
to
2b63b02
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/thestk/rtaudio/releases. meta.description for rtaudio is: A set of C++ classes that provide a cross platform API for realtime audio input/output meta.homepage for rtaudio is: https://www.music.mcgill.ca/~gary/rtaudio/ Updates performed
To inspect upstream changesImpactChecks done (click to expand)
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 40 packages failed to build:
1 package built:
Maintainer pingscc @magnetophon for testing. |
LGTM |
@ofborg eval |
Result of 34 packages failed to build:
20 packages built:
Main failure is |
soft bump |
r-ryantm is a bot, if there are build failures a new pr must be made |
Result of 1 package marked as broken and skipped:
33 packages failed to build:
21 packages built:
I'm not in favour of landing this as-is, as it would still break the significant amount of RtAudio uses. If RtAudio 6.x is urgently desired, then smth like a separate Tickets need to be raised / fixes need to be sent in the respective upstreams to make them compatible with 6.x. |
At least one of those applications (zrythm) has been updated to work with rtaudio v6, but is waiting on this package to be updated before our package can be updated. zrythm is waiting on the gnome 46 PR to be merged too, so this is not its only holdup. I don't know about the radio packages though. Merging as rtaudio_6 might be the way to go for now. SoapyAudio hasn't been updated in a while and there has been an issue to update it since last year, so it looks like there's a chance it might not get updated to support rtaudio 6. |
To avoid this "who should be bumped first" situation, maybe the commit(s) with the v6 changes could be applied/reverted based on the rtaudio version? i.e. what #246368 tried to do.
Most of the failures come from their dependency soapyaudio FTBFS. |
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/thestk/rtaudio/releases.
meta.description for rtaudio is: A set of C++ classes that provide a cross platform API for realtime audio input/output
meta.homepage for rtaudio is: https://www.music.mcgill.ca/~gary/rtaudio/
Closes #274031.
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done (click to expand)
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review
run on x86_64-linux 142 packages failed to build:
1 package built:
Maintainer pings
cc @magnetophon for testing.