Skip to content

ipu7: init - #542085

Open
aoli-al wants to merge 5 commits into
NixOS:masterfrom
aoli-al:ipu7-clean
Open

ipu7: init#542085
aoli-al wants to merge 5 commits into
NixOS:masterfrom
aoli-al:ipu7-clean

Conversation

@aoli-al

@aoli-al aoli-al commented Jul 15, 2026

Copy link
Copy Markdown
Member

This patch adopts changes from #479283. Main diff:

We need this out-of-tree kernel module because ipu7-psys is not in-tree. Adding ipu7-drivers and ipu7-camera-* allows user to use hardware ISP, PSys.

Tested on dell xps 14. Camera works with hardware accelerator.

Things done

@nixpkgs-ci
nixpkgs-ci Bot requested a review from a team July 15, 2026 05:43
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (new) This PR adds a new package 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: kernel The Linux kernel 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: hardware Drivers, Firmware and Kernels labels Jul 15, 2026
Co-Authored-By: Ao Li <aoli.al@hotmail.com>
Co-Authored-By: Atlas Yu <pseudoc@163.com>
@aoli-al
aoli-al requested a review from K900 July 15, 2026 05:59
@aoli-al

aoli-al commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha (25f82fc)

Command: nixpkgs-review pr 542085
Commit: 57438b477883fe46a082be7fd141eab64edb5a73 (subsequent changes)
Merge: 6260242fd2b9bb80a6fb3edcbcdc7bdc2cddba5a

Logs: https://github.com/aoli-al/nixpkgs-review-gha/actions/runs/29392727227/attempts/1


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 14 packages built:
  • gst_all_1.icamerasrc-ipu6
  • gst_all_1.icamerasrc-ipu6ep
  • gst_all_1.icamerasrc-ipu6epmtl
  • gst_all_1.icamerasrc-ipu75xa
  • gst_all_1.icamerasrc-ipu7x
  • ipu7-camera-bins
  • ipu75xa-camera-hal
  • ipu7x-camera-hal
  • linuxKernel.packages.linux_6_12.ipu7-drivers
  • linuxPackages.ipu7-drivers (linuxKernel.packages.linux_6_18.ipu7-drivers)
  • linuxPackages_latest.ipu7-drivers (linuxKernel.packages.linux_7_1.ipu7-drivers)
  • linuxPackages_xanmod.ipu7-drivers (linuxKernel.packages.linux_xanmod.ipu7-drivers)
  • linuxPackages_xanmod_latest.ipu7-drivers (linuxKernel.packages.linux_xanmod_latest.ipu7-drivers, linuxPackages_xanmod_stable.ipu7-drivers)
  • linuxPackages_zen.ipu7-drivers (linuxKernel.packages.linux_zen.ipu7-drivers)

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@aoli-al
aoli-al requested a review from pseudocc July 15, 2026 15:20
pseudocc added a commit to pseudocc/nixpkgs that referenced this pull request Jul 17, 2026
pseudocc added a commit to pseudocc/nixpkgs that referenced this pull request Jul 17, 2026

@pseudocc pseudocc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to apply these commits on top of nixos-26.05, but got compile errors during linkage and this pseudocc@9b0fa8f could fix the build.

/nix/store/39lyf5g2iz4jd2r6q4g5whk9vw09zglj-binutils-2.46/bin/ld.bfd: JsonCommonParser.cpp:(.text+0x363): undefined reference to `Json::Value::isMember(char const*) const'

Comment thread pkgs/by-name/ip/ipu7x-camera-hal/package.nix
@pseudocc

Copy link
Copy Markdown
Contributor

Works fine on ThinkPad X1 2-in-1 Gen 10 (ipu7, sensor ov08x40), test on https://mozilla.github.io/webrtc-landing/gum_test.html (Chromium 150).

aoli-al and others added 4 commits July 17, 2026 09:22
Co-Authored-By: Ao Li <aoli.al@hotmail.com>
Co-Authored-By: Atlas Yu <pseudoc@163.com>
Out-of-tree IPU7 PSys kernel module. On kernels >= 6.17 the IPU7 core
and ISys ship in mainline (drivers/staging/media/ipu7) but PSys does
not, so upstream's Makefile builds only PSys and links it against the
in-tree core and ISys.

Co-Authored-By: Ao Li <aoli.al@hotmail.com>
Co-Authored-By: Atlas Yu <pseudoc@163.com>
Co-Authored-By: Ao Li <aoli.al@hotmail.com>
Co-Authored-By: Atlas Yu <pseudoc@163.com>
Co-Authored-By: Ao Li <aoli.al@hotmail.com>
Co-Authored-By: Atlas Yu <pseudoc@163.com>

@pseudocc pseudocc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 20, 2026
@nixos-discourse

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/3191

@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jul 30, 2026
@nixos-discourse

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/3221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: hardware Drivers, Firmware and Kernels 6.topic: kernel The Linux kernel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants