librelane: 3.0.4 -> 3.0.8 - #551846
Merged
Merged
Conversation
Assisted-by: Claude Code (Claude Sonnet 5)
Add __structuredAttrs = true. Assisted-by: Claude Code (Claude Sonnet 5)
Contributor
Author
|
@GaetanLepage re: `pythonRelaxDeps = [ "click" ]` — yes, still needed: librelane 3.0.8's own `pyproject.toml` pins `click>=8,<8.3`, but nixpkgs currently pins `click` at 8.3.3, which is outside that range. Without the relax it'd fail dependency resolution. Also pushed `__structuredAttrs = true` per your other suggestion. |
Contributor
|
Man, I (personally) have absolutely no issue with you using agents to help you with nixpkgs contributions. |
GaetanLepage
approved these changes
Aug 13, 2026
gonsolo
added a commit
to gonsolo/Borg
that referenced
this pull request
Aug 17, 2026
klayout 0.30.7 (the previous pin) silently misses a real DRC violation (GR.2, sealring corner geometry) that 0.30.10 correctly catches -- traced by isolating the exact KLayout release across three toolchains while investigating wafer-space/gf180mcu-project-template#77. librelane bumps to 3.0.8 along the way (requested once NixOS/nixpkgs#551846 merged). yosys is 0.68 at this pin, which fixes the autoname O(iterations x module size) blowup upstream (YosysHQ/yosys#6050), so the local yosysFixed patch and its packages.${system} export are no longer needed. Pinned nixpkgs just past NixOS/nixpkgs#551902 (sv-lang_10 fix for fmt 12) rather than a same-day master commit or the nixos-unstable channel pointer -- the latter predates that fix by ~8h and hits the exact sv-lang build failure it resolves; a bleeding-edge commit has had no time to build/cache upstream at all. nixpkgs' own default python3 is 3.14 here, which breaks two of our deps with no released fix yet: - or-tools (openroad's dependency, transitively librelane's): its meta.broken is conditioned on pythonAtLeast "3.14" (real pybind11 test failures, NixOS/nixpkgs#551898 still open). Overridden back to python313 directly on that one package rather than the whole set, so openroad/librelane/klayout/yosys/pythonEnv all stay on nixpkgs' own default and keep hitting the binary cache. Also disables or-tools' own checkPhase: even on 3.13 it has one unrelated failure (python_contrib_check_dependencies, a stale pkg_resources/setuptools deprecation check -- 610/611 other tests pass), the same workaround NixOS/nixpkgs#551846's author used. - cocotb: no released Python 3.14 support upstream (cocotb/cocotb's setup.py hard-caps at 3.13; 3.14 support exists only on cocotb's unreleased master). Pinned to python313Packages.cocotb as its own nativeBuildInputs entry rather than folded into pythonEnv -- it doesn't need to share an interpreter with anything else, since test/soc/Makefile drives it via `cocotb-config --makefiles`, which points at cocotb's own bundled interpreter internally. Also: p.peakrdl -> p.peakrdl-cli (upstream rename), and beamer added to borgTexlive for docs/talk (ORConf 2026 slides, next commit). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018nC29cmxJCM5eiBBmWNY9q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update librelane from 3.0.4 to 3.0.8.
Changelog: https://github.com/librelane/librelane/releases/tag/3.0.8
Pre-existing, unrelated blocker
Same as #551828:
librelanewrapsopenroadinto its runtime PATH (postFixup), sobuilding it pulls in
openroad'sor-toolsbuildInput, which is currentlymeta.broken = trueon the default toolchain (python3.pythonAtLeast "3.14"). This isunrelated to librelane itself and pre-existing on
masterregardless of this bump; see#551828 for the full diagnosis (real pybind11 2.13.6/Python 3.14 test failure, plus a
second, independent
pkg_resources/setuptoolsdeprecation issue even under Python 3.13).Verified
librelaneitself (Python packaging,postInstall,wrapProgram) builds andwraps cleanly by scoping past the unrelated
or-toolsblocker for local verification(
or-toolson python3.13 with its own unrelateddoCheckskipped) — build succeeded,pythonImportsCheckPhasepassed.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.AI disclosure: this PR description and the git/gh mechanics (branch, commit, push, PR
creation) were drafted/executed with the assistance of Claude Code (Claude Sonnet 5); see
the
Assisted-by:trailer on the commit. The version bump was produced vianix-update.