Marking NobleSprite with animation dirty before drawing#65
Open
stiv-iv wants to merge 7 commits intoNobleRobot:mainfrom
Open
Marking NobleSprite with animation dirty before drawing#65stiv-iv wants to merge 7 commits intoNobleRobot:mainfrom
stiv-iv wants to merge 7 commits intoNobleRobot:mainfrom
Conversation
Fixed NobleSprite animation drawing in cases, when Graphics.sprite.getAlwaysRedraw() == false
Mark sprite dirty last time in pause() and stop() methods before blocking updates.
✅ Deploy Preview for cheery-choux-736619 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
added 2 commits
December 23, 2025 03:18
Update scene before drawing sprites
Fix NobleSprite: Dont delete coords for sprites before adding
assada
added a commit
to assada/NobleEngine
that referenced
this pull request
Feb 24, 2026
…waysRedraw=false
assada
added a commit
to assada/NobleEngine
that referenced
this pull request
Feb 24, 2026
PR NobleRobot#65 swapped the order so scene:update() runs before Graphics.sprite.update(). This breaks scenes that draw UI elements (Noble.Menu, Noble.Text, manual image:draw) in their update() method, because sprite.update() redraws dirty regions on top, erasing the UI. The markDirty() fixes from PR NobleRobot#65 in NobleSprite work correctly without the order swap, since sprite:update() and sprite:draw() both run inside Graphics.sprite.update().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed NobleSprite animation drawing in cases, when Graphics.sprite.getAlwaysRedraw() == false