fix: pin Cargo.lock to unbreak CI dependency resolution - #102
Merged
Conversation
ed25519-dalek published a breaking 3.0.0 that soroban-env-host's testutils can't compile against (ChaCha20Rng no longer satisfies its CryptoRng bound). Without a committed lockfile, every fresh resolution -- including CI once its cache rolls over -- picks up the break. Pin the whole graph so builds are reproducible and this class of upstream breakage can't reoccur silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--features testutilsbecauseed25519-dalekpublished a breaking3.0.0thatsoroban-env-host's test PRNG helper can't satisfy (ChaCha20Rngno longer implements theCryptoRngboundSigningKey::generaterequires).Cargo.lockwas gitignored, so every fresh dependency resolution — including CI once its cache rolls over — picks up the break. Confirmed this fails identically on unmodifiedmain, not something introduced by other work.Cargo.lock, pinned toed25519-dalek 2.2.0, so builds are reproducible and this class of upstream breakage can't reoccur silently.Test plan
cargo test --features testutils— 24 passed, 0 failedcargo clippy --all-targets --features testutils -- -D warnings— cleancargo build --release --target wasm32v1-none— succeeds