Skip to content

[WIP]Fix black_box on benchmarks#1585

Merged
teofr merged 1 commit intoteofr/add-v2-slang-benchmarksfrom
teofr/black-boxing-benchmarks
Apr 1, 2026
Merged

[WIP]Fix black_box on benchmarks#1585
teofr merged 1 commit intoteofr/add-v2-slang-benchmarksfrom
teofr/black-boxing-benchmarks

Conversation

@teofr
Copy link
Copy Markdown
Contributor

@teofr teofr commented Mar 27, 2026

This PR addresses this comment #1572 (comment) (and similar ones). It makes sure that every function being benchmarked has its arguments and its result wrapped around black_box, to avoid any optimizations to skew results.

Testing

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 27, 2026

⚠️ No Changeset found

Latest commit: 77a367b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@teofr teofr mentioned this pull request Mar 27, 2026
2 tasks
@teofr teofr force-pushed the teofr/black-boxing-benchmarks branch from 382ac22 to 77a367b Compare April 1, 2026 19:07
@teofr teofr force-pushed the teofr/add-v2-slang-benchmarks branch from 6894c79 to 5b618a5 Compare April 1, 2026 19:07
@teofr teofr merged commit 77a367b into teofr/add-v2-slang-benchmarks Apr 1, 2026
4 of 14 checks passed
@teofr teofr deleted the teofr/black-boxing-benchmarks branch April 1, 2026 19:22
@teofr teofr restored the teofr/black-boxing-benchmarks branch April 1, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant