Conversation
|
ggiraldez
force-pushed
the
ggiraldez/v2-migrate-passes
branch
from
29a3535 to
bc864d2
Compare
ggiraldez
force-pushed
the
ggiraldez/v2-migrate-ast
branch
2 times, most recently
from
65c6bfe to
ac7e834
Compare
OmarTawfik
reviewed
Apr 8, 2026
| @@ -44,7 +45,41 @@ impl CompilationUnit { | |||
| self.files.get(id).cloned() | |||
| } | |||
|
|
|||
| // TODO: this should be semi-public | |||
Contributor
There was a problem hiding this comment.
Adding a note about migrating the new APIs from #1593:
ggiraldez
force-pushed
the
ggiraldez/v2-refactor-semantic
branch
from
8cfd5a0 to
6917bfd
Compare
ggiraldez
force-pushed
the
ggiraldez/v2-migrate-ast
branch
2 times, most recently
from
091a9aa to
5dc7adb
Compare
ggiraldez
force-pushed
the
ggiraldez/v2-refactor-semantic
branch
from
6917bfd to
049758d
Compare
ggiraldez
force-pushed
the
ggiraldez/v2-migrate-ast
branch
from
5dc7adb to
e917ee5
Compare
ggiraldez
force-pushed
the
ggiraldez/v2-migrate-ast
branch
from
e917ee5 to
592548c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a more or less straight migration of the remaining functionality in v1 to v2, with the difference that it's now split in the new v2 crates according to area of function. This includes:
get_file_ast_rootand a couple other convenience methods added toCompilationUnittests/backendported to their respective v2 crateThis PR should bring (almost) feature parity to v2 in terms of AST API. Main missing feature is location information for AST nodes.