npm: bump prettier from 3.5.3 to 3.8.1#1646
Merged
Conversation
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
Author
|
Will block this on #1594 to make sure I don't break it. |
nebasuke
force-pushed
the
bas/bump-prettier-3.8.1
branch
2 times, most recently
from
cdd8232 to
c96e1fc
Compare
Reformat markdown and YAML snapshot files to match prettier 3.8 style.
The CST snapshot YAML files were written via `write_file_raw` which skips formatting. With prettier 3.8, long YAML lines (>120 chars) get reformatted using explicit mapping syntax, causing CI test failures when `verify_contents` string-compares the renderer output against the prettier-formatted committed files. Add "yml" to the prettier formatter match arm and switch the snapshot runner to `write_file_formatted` so generated YAML always matches prettier's output.
Apply the same fix as V1: switch the V2 CST snapshot runner from write_file_raw to write_file_formatted so generated YAML goes through prettier before being written or verified.
nebasuke
force-pushed
the
bas/bump-prettier-3.8.1
branch
from
c96e1fc to
cd4b4d9
Compare
Prettier 3.8 reformats long YAML mapping keys to explicit `? :` syntax, which required switching snapshot writers to `write_file_formatted`. This spawns a separate prettier process per snapshot file (~1,294 total), adding minutes to the test phase. Instead, set printWidth: 9999 for snapshot YAML in .prettierrc so prettier is a no-op, and revert both V1 and V2 runners back to `write_file_raw`.
No .yml files go through write_file_formatted anymore, so the match arm added for the prettier 3.8 fix is now dead code. Revert to the original set of prettier-formatted extensions.
Prettier 3.8 removes blank lines between list item descriptions and indented sub-lists in markdown. Some renderers depend on these blank lines, and changelogs are auto-generated by changesets anyway. Restore the original formatting from main for affected files.
nebasuke
force-pushed
the
bas/bump-prettier-3.8.1
branch
from
52b5a57 to
3719900
Compare
teofr
approved these changes
Apr 14, 2026
teofr
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
printWidth: 9999for generated YAML snapshots so prettier doesn't reformat long mapping keys to explicit? :syntax (introduced in prettier 3.8)CHANGELOG.mdfiles from prettier so we don't end up reformattingchangesetgenerated files as 3.8 removes blank lines before indented sub-lists