Skip to content

fix: connecting and disconnecting state issue #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: connecting and disconnecting state issue #511

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4313050
fix: STATE_CONNECTING blocked due to it already being default value
juliansteenbakker Nov 17, 2025
694ecaa
fix: enable multiple status updates being passed through
juliansteenbakker Nov 17, 2025
04abf16
fix: connection state never being set to STATE_DISCONNECTING
juliansteenbakker Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/dfu/src/main/java/no/nordicsemi/android/dfu/DfuBaseService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,7 @@ public abstract class DfuBaseService extends IntentService implements DfuProgres
* Stores the last progress percent. Used to prevent from sending progress notifications with
* the same value.
*/
private int mLastProgress = -1;
private int mLastProgress = 0;
/* package */ DfuProgressInfo mProgressInfo;
private long mLastNotificationTime;

Expand Down Expand Up @@ -1661,6 +1661,8 @@ protected void disconnect(@NonNull final BluetoothGatt gatt) {
if (mConnectionState == STATE_DISCONNECTED)
return;

mConnectionState = STATE_DISCONNECTING;

sendLogBroadcast(LOG_LEVEL_VERBOSE, "Disconnecting...");
mProgressInfo.setProgress(PROGRESS_DISCONNECTING);

Expand Down Expand Up @@ -1763,7 +1765,7 @@ protected void refreshDeviceCache(@NonNull final BluetoothGatt gatt, final boole
public void updateProgressNotification() {
final DfuProgressInfo info = mProgressInfo;
final int progress = info.getProgress();
if (mLastProgress == progress)
if (mLastProgress == progress && progress >= 0 && progress <= 100)
return;

mLastProgress = progress;
Expand Down