Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Update dockerfile version to support pnpm #176

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

NaoCoding
Copy link
Contributor

@NaoCoding NaoCoding commented Mar 11, 2025

The current dockerfile uses node:16.14-alpine as the source to build the docker compose.
However, the project uses [email protected] as its pnpm version, which is conflicted and cannot be run with node 16,
causes error when building docker compose.

Therefore, this pull request aims to modify the dockerfile to node:22-alpine as the source for docker compose,
which solve the error and make itself to work normally.

On the other hand, I remove the corepack prepare [email protected] in dockerfile since the pnpm attributions have been set in package.json

@Bogay
Copy link
Member

Bogay commented Mar 11, 2025

looks like sandbox issue caused the CI fail. should not be issue of this PR, I'll merge it anyway.

@Bogay Bogay merged commit 3aa6e0c into Normal-OJ:main Mar 11, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants