Merged
Conversation
EdgarButtner
force-pushed
the
#4087-Individual-Teamtype-Page
branch
from
fdbc462 to
5e596fc
Compare
staysgt
requested changes
Apr 5, 2026
Contributor
staysgt
left a comment
staysgt
left a comment
There was a problem hiding this comment.
Just a few pretty small comments, looks great overall!
| const GuestTeamPage: React.FC<GuestTeamPageProps> = ({ teamTypeId }) => { | ||
| const isMobilePortrait = useMediaQuery('(max-width:480px)'); | ||
| const { isLoading: teamsIsLoading, isError: teamsIsError, data: allTeams, error: teamsError } = useAllTeams(); | ||
| const teams = allTeams?.filter((team) => team.teamType?.teamTypeId === teamTypeId); |
Contributor
There was a problem hiding this comment.
I think you need to move the filtering logic down a few lines after we check that allTeams exists. I'm getting this error when there are no teams associated with a team type, it shouldn't be displaying this error, because there isn't an error, theres just no teams associated with the division.
| const TeamOrDivisionPage: React.FC = () => { | ||
| const { teamId } = useParams<{ teamId: string }>(); | ||
| const user = useCurrentUser(); | ||
| const { data: teamTypes } = useAllTeamTypes(); |
Contributor
There was a problem hiding this comment.
Can you destructure this fully, so we have the whole { isLoading: teamsLoading, isError: isTeamsError, data: teams, error: teamsError } + the conditional checks
| import { NERButton } from '../../components/NERButton'; | ||
| import { Link as RouterLink } from 'react-router-dom'; | ||
|
|
||
| interface TeamTypeCardProps { |
Contributor
There was a problem hiding this comment.
Can you rename this to GuestSubteamCardProps instead
…s and destucturing teamTypes in Teams.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added a GuestDivisionPage with a GuestTeamPage and a GuestSubteamCard. The GuestTeamPage renders GuestSubteamCards as needed. I also needed to change Team.tsx to make sure the right TeamSpecificPage was rendered.
Notes
Might want to change some filenames. For example GuestSubteamCard might be better as GuestTeamTypeCard but idk if we want to stick to.
Test Cases
No tests needed. (I think)
Screenshots
Img for fullscreen subteam:
Img for mobile subteam:
Img for specific subteam page (guest version):
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes # (issue #)
#4087