Open
Conversation
wavehassman
requested changes
Apr 10, 2026
Contributor
wavehassman
left a comment
wavehassman
left a comment
There was a problem hiding this comment.
Great job sarah! Just a couple of changes
| stockDescription?: string, | ||
| discountDescription?: string | ||
| discountDescription?: string, | ||
| logoImage?: Express.Multer.File |
Contributor
There was a problem hiding this comment.
make sure to update the documentation
| let logoImageId: string | undefined; | ||
| if (logoImage) { | ||
| const logoImageData = await uploadFile(logoImage); | ||
| if (!logoImageData?.id || !logoImageData?.name) { |
Contributor
There was a problem hiding this comment.
this check is unecessary
uploadFile either returns the name and id or throws
you can just get the id right from the uploadFile call
| stockDescription?: string, | ||
| discountDescription?: string | ||
| discountDescription?: string, | ||
| logoImage?: Express.Multer.File |
Contributor
There was a problem hiding this comment.
also here for comments
| let logoImageId: string | undefined; | ||
| if (logoImage) { | ||
| const logoImageData = await uploadFile(logoImage); | ||
| if (!logoImageData?.id || !logoImageData?.name) { |
Contributor
There was a problem hiding this comment.
same thing with the error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added sponsor logo image id into backend endpoints.
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4101