feat(store): added mcu onboarding support #416
Conversation
Ticket: MEN-8583 Signed-off-by: Mikita Pilinka <[email protected]>
| export const sliceName = 'onboarding'; | ||
|
|
||
| export type OnboardingApproach = 'virtual' | 'physical'; | ||
| export type OnboardingApproach = 'virtual' | 'physical' | 'mcu' | ''; |
There was a problem hiding this comment.
is there a reason to have the ''? if a user selects one that should be set, otherwise the slice already gets a OnboardingApproach | null in the type definition - so an empty state would be covered by this already...
There was a problem hiding this comment.
null will work; I didn't notice it in the slice definition. 🤦 Thanks for catching it. The problem was that in some cases a wrongly deducted approach was saved to the user settings. I will update
| let approach = ''; | ||
| if (deviceType.some(type => type.startsWith('qemu'))){ | ||
| approach = 'virtual' | ||
| } else if (deviceType.some(type => type === 'esp32-s3')) { |
There was a problem hiding this comment.
considering the instructions in the dialog, I would assume the type selection might be too narrow (e.g. they use some other mcu that's zephyr compatible...) - is there something else available to identify mcus?
There was a problem hiding this comment.
I've recently noticed that there is a tier in the device object now, which looks like a better candidate for approach deduction. I'll take a closer look and update accordingly. Otherwise I don't see other options
Ticket: MEN-8583