Skip to content

fix(skills): pass evolved_full to skill_structure validator #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlvitorasso wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(skills): pass evolved_full to skill_structure validator #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion evolution/skills/evolve_skill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,13 @@ def evolve(
evolved_full = reassemble_skill(skill["frontmatter"], evolved_body)

# ── 7. Validate evolved skill ───────────────────────────────────────
# Pass `evolved_full` (frontmatter + body) so the `skill_structure`
# constraint can verify the YAML frontmatter / name / description.
# Passing `evolved_body` here causes that constraint to always fail and
# routes valid evolutions into the FAILED path even when the assembled
# skill is well-formed (and gets saved correctly on line ~206).
console.print(f"\n[bold]Validating evolved skill[/bold]")
evolved_constraints = validator.validate_all(evolved_body, "skill", baseline_text=skill["body"])
evolved_constraints = validator.validate_all(evolved_full, "skill", baseline_text=skill["body"])
all_pass = True
for c in evolved_constraints:
icon = "✓" if c.passed else "✗"
Expand Down