fix: use subprocess HOME for ~ expansion in skill config values#12331
Closed
kagura-agent wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix: use subprocess HOME for ~ expansion in skill config values#12331kagura-agent wants to merge 1 commit intoNousResearch:mainfrom
kagura-agent wants to merge 1 commit intoNousResearch:mainfrom
Conversation
|
✓ Automated scan: no security concerns. Path expansion fix. |
…Research#12260) resolve_skill_config_values() was using os.path.expanduser() which resolves ~ against the Python process HOME (/opt/data in containers). Replace with a helper that uses get_subprocess_home() so ~ expands to the correct per-profile home directory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kagura-agent
force-pushed
the
fix/skill-config-home-expansion
branch
from
aa30d34 to
434ff17
Compare
alt-glitch
added
type/bug
Collaborator
Contributor
Author
|
Closing in favor of #12736 which takes a cleaner approach by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12260
resolve_skill_config_values()usedos.path.expanduser()to expand~in skill config defaults, which resolves against the Python process's HOME (e.g./opt/datain containers) rather than the subprocess HOME.Changes:
_expand_home()helper that usesget_subprocess_home()fromhermes_constantsresolve_skill_config_values()(skill dirs + config values)os.path.expanduser()whenget_subprocess_home()returnsNoneresolve_skill_config_values()