fix(matrix): implement device verification and stable device_id for E2EE#3524
Open
devorun wants to merge 2 commits intoNousResearch:mainfrom
Open
fix(matrix): implement device verification and stable device_id for E2EE#3524devorun wants to merge 2 commits intoNousResearch:mainfrom
devorun wants to merge 2 commits intoNousResearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3521
Problem
The Matrix gateway was unable to handle encrypted (E2EE) messages effectively for two reasons:
device_id, the bot generated a new identity on every restart, causing users' clients to treat it as an "untrusted/unknown device."Solution
MATRIX_DEVICE_IDenvironment variable. This ensures the bot maintains a consistent identity across restarts, allowing for persistent trust._on_key_verification). The bot will now automatically accept and confirm verification requests from users listed inMATRIX_ALLOWED_USERS.gateway/config.pyto officially recognize and mapMATRIX_DEVICE_IDandMATRIX_ALLOWED_USERSfrom environment variables to the Matrix platform configuration.Testing
nio.AsyncClientcorrectly receives thedevice_id.KeyVerificationStartevent.Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs