fix: add async_is_safe_url() to avoid blocking event loop on DNS lookup#3600
Open
memosr wants to merge 1 commit intoNousResearch:mainfrom
Open
fix: add async_is_safe_url() to avoid blocking event loop on DNS lookup#3600memosr wants to merge 1 commit intoNousResearch:mainfrom
memosr wants to merge 1 commit intoNousResearch:mainfrom
Conversation
is_safe_url() calls socket.getaddrinfo() which is synchronous and blocks the calling thread. It is called from web_extract_tool() and web_crawl_tool() which are both async. On a slow or unresponsive DNS server this freezes the entire asyncio event loop — blocking all gateway message handling for all users until DNS responds. Fix extracts the hostname check into _check_hostname() and adds async_is_safe_url() which runs the blocking DNS call in a thread pool executor via loop.run_in_executor(). The original is_safe_url() is preserved for sync callers (vision_tools.py redirect hook).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_safe_url() calls socket.getaddrinfo() which is synchronous and blocks the calling thread. It is called from web_extract_tool() and web_crawl_tool() which are both async. On a slow or unresponsive DNS server this freezes the entire asyncio event loop — blocking all gateway message handling for all users until DNS responds.
Fix extracts the hostname check into _check_hostname() and adds async_is_safe_url() which runs the blocking DNS call in a thread pool executor via loop.run_in_executor(). The original is_safe_url() is preserved for sync callers (vision_tools.py redirect hook).
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs