fix(browser): guard LLM response content against None in snapshot and vision#3642
Merged
fix(browser): guard LLM response content against None in snapshot and vision#3642
Conversation
… vision Reasoning-only models (DeepSeek-R1, QwQ) return content=None, causing null snapshots from _extract_relevant_content and null analysis from browser_vision. Follow-up to #3449 which applied the same guard elsewhere. - _extract_relevant_content: falls back to truncated raw snapshot - browser_vision: falls back to descriptive message
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of PR #3532 (binhnt92). Follow-up to #3449.
Reasoning-only models (DeepSeek-R1, QwQ via OpenRouter) return
content=None, causing null snapshots and null vision analysis. Guards both sites with(content or "").strip()and sensible fallbacks.7 tests, 54 browser tests total passing.
Closes #3532
Co-Authored-By: binhnt92 [email protected]