tighten admin pssword - #172
Open
koder-ns wants to merge 1 commit into
Open
Conversation
Contributor
|
@koder-ns resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #119
Description
Security Gap - User-helper.isValidPassword is referenced in auth.service.ts but lacks a clear, documented password policy. This creates inconsistent password requirements and potential security vulnerabilities.
This PR implements a NIST SP 800-63B compliant password validation system with:
Minimum length requirements (12+ chars for admins, 8+ for standard users)
Entropy-based strength validation (not just complexity rules)
Breach detection via Have I Been Pwned (HIBP) API
Rejection of common/predictable passwords