-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet list package checks if restore is current #14065
base: dev
Are you sure you want to change the base?
Conversation
Thank you @zivkan for the ideas in our offline discussion. |
<!-- Why is this the best design compared to other designs? --> | ||
<!-- What other designs have been considered and why weren't they chosen? --> | ||
<!-- What is the impact of not doing this? --> | ||
- **Force Restore Every Time**: Automatically run restore when dotnet list package is called. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should say "Implicitly run restore which might do a no-op with an option to disable via a command-line argument --no-restore
which other commands have. This would probably be me vote personally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, as per the spec guide, I think we should make a good argument about why we're not pursuing certain alternative.
In this case, those drawbacks are not obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec looks great, complete and there's plenty of technical detail.
We should explore @jeffkl's idea and get a sense of whether we'd want to make that breaking change (or if we've explored it in more detail, we should details about why we're not pursuing that direction.
<!-- Why is this the best design compared to other designs? --> | ||
<!-- What other designs have been considered and why weren't they chosen? --> | ||
<!-- What is the impact of not doing this? --> | ||
- **Force Restore Every Time**: Automatically run restore when dotnet list package is called. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- Why is this the best design compared to other designs? --> | ||
<!-- What other designs have been considered and why weren't they chosen? --> | ||
<!-- What is the impact of not doing this? --> | ||
- **Force Restore Every Time**: Automatically run restore when dotnet list package is called. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, as per the spec guide, I think we should make a good argument about why we're not pursuing certain alternative.
In this case, those drawbacks are not obvious.
Rendered: https://github.com/NuGet/Home/blob/e767bd9abb67589d3892b1382f70e8fc72a8ca13/accepted/2025/dotnet-list-package-restore-no-op-check.md