Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet list package checks if restore is current #14065

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Nigusu-Allehu
Copy link
Contributor

@Nigusu-Allehu Nigusu-Allehu commented Jan 23, 2025

@Nigusu-Allehu
Copy link
Contributor Author

Thank you @zivkan for the ideas in our offline discussion.

@Nigusu-Allehu Nigusu-Allehu marked this pull request as ready for review January 23, 2025 19:19
@Nigusu-Allehu Nigusu-Allehu requested a review from a team as a code owner January 23, 2025 19:19
@Nigusu-Allehu Nigusu-Allehu requested a review from jeffkl January 23, 2025 19:20
<!-- Why is this the best design compared to other designs? -->
<!-- What other designs have been considered and why weren't they chosen? -->
<!-- What is the impact of not doing this? -->
- **Force Restore Every Time**: Automatically run restore when dotnet list package is called.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should say "Implicitly run restore which might do a no-op with an option to disable via a command-line argument --no-restore which other commands have. This would probably be me vote personally.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13406 is the tracking issue.

It'd be worth to call out the challenges if we were to go that direction.

We can also see if @OliaG can help with some CD to see if the breaking is worth it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, as per the spec guide, I think we should make a good argument about why we're not pursuing certain alternative.
In this case, those drawbacks are not obvious.

Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec looks great, complete and there's plenty of technical detail.

We should explore @jeffkl's idea and get a sense of whether we'd want to make that breaking change (or if we've explored it in more detail, we should details about why we're not pursuing that direction.

<!-- Why is this the best design compared to other designs? -->
<!-- What other designs have been considered and why weren't they chosen? -->
<!-- What is the impact of not doing this? -->
- **Force Restore Every Time**: Automatically run restore when dotnet list package is called.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13406 is the tracking issue.

It'd be worth to call out the challenges if we were to go that direction.

We can also see if @OliaG can help with some CD to see if the breaking is worth it.

<!-- Why is this the best design compared to other designs? -->
<!-- What other designs have been considered and why weren't they chosen? -->
<!-- What is the impact of not doing this? -->
- **Force Restore Every Time**: Automatically run restore when dotnet list package is called.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, as per the spec guide, I think we should make a good argument about why we're not pursuing certain alternative.
In this case, those drawbacks are not obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants