Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badly specified framework leads to a non coded error in Visual Studio #12943

Open
nkolev92 opened this issue Oct 17, 2023 · 6 comments · May be fixed by NuGet/NuGet.Client#6291
Open

Badly specified framework leads to a non coded error in Visual Studio #12943

nkolev92 opened this issue Oct 17, 2023 · 6 comments · May be fixed by NuGet/NuGet.Client#6291
Assignees
@Nigusu-Allehu
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore Priority:2 Issues for the current backlog. Product:VS.Client SeQuality Type:Bug

Comments

@nkolev92
Copy link
Member

Related to #12939.

Take a project like for example:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFrameworks>net6.0;net7.0;net.8.0</TargetFrameworks>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
  </PropertyGroup>

</Project>

The steps are:

  1. Open a project file.
  2. Change the tfm to a non-existing one, or a bad one.
  3. Get a non-coded error.

This is currently being treated as a badly constructed spec, so an internal NuGet error, but in reality, it's a misconfigured project.
Misconfigured projects should fail in a coded way, https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1105.
@nkolev92 nkolev92 added Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Type:Bug Functionality:Restore labels Oct 17, 2023
This was referenced Oct 17, 2023
Merged
Merged
@nkolev92 nkolev92 added Triage:NeedsMoreInfo and removed Priority:1 High priority issues that must be resolved in the current sprint. labels Oct 30, 2023
@nkolev92
Copy link
Member Author

I think that this might be a regression.

@v-luzh Can you please help us understand when this regressed?

I'd use the following in the project file.

<TargetFrameworks>net.6.0;net472</TargetFrameworks>

A major/minor version is enough.

@nkolev92 nkolev92 modified the milestones: 6.8, 6.9 Oct 31, 2023
@jeffkl jeffkl added the WaitingForCustomer Applied when a NuGet triage person needs more info from the OP label Nov 2, 2023
@ghost ghost added the Status:No recent activity No recent activity. label Nov 17, 2023
@ghost
Copy link

ghost commented Nov 17, 2023

This issue has been automatically marked as stale because we have not received a response in 14 days. It will be closed if no further activity occurs within another 14 days of this comment.

@nkolev92
Copy link
Member Author

Making sure @v-luzh sees this: #12943 (comment).

Can you help us understand whether/when this regressed?

@ghost ghost added WaitingForClientTeam Customer replied, needs attention from client team. Do not apply this label manually. and removed WaitingForCustomer Applied when a NuGet triage person needs more info from the OP Status:No recent activity No recent activity. labels Nov 17, 2023
@jeffkl jeffkl added WaitingForCustomer Applied when a NuGet triage person needs more info from the OP and removed WaitingForClientTeam Customer replied, needs attention from client team. Do not apply this label manually. labels Nov 17, 2023
@ghost ghost added the Status:No recent activity No recent activity. label Dec 2, 2023
@ghost
Copy link

ghost commented Dec 2, 2023

This issue has been automatically marked as stale because we have not received a response in 14 days. It will be closed if no further activity occurs within another 14 days of this comment.

@nkolev92
Copy link
Member Author

nkolev92 commented Dec 4, 2023

Sent an e-mail about this.

@ghost ghost added WaitingForClientTeam Customer replied, needs attention from client team. Do not apply this label manually. and removed WaitingForCustomer Applied when a NuGet triage person needs more info from the OP Status:No recent activity No recent activity. labels Dec 4, 2023
@nkolev92
Copy link
Member Author

image

Not a regression, but definitely a failure that could use some improvement.

@ghost ghost removed the WaitingForClientTeam Customer replied, needs attention from client team. Do not apply this label manually. label Dec 11, 2023
@ghost ghost added the WaitingForCustomer Applied when a NuGet triage person needs more info from the OP label Dec 11, 2023
@nkolev92 nkolev92 removed this from the 6.9 milestone Dec 11, 2023
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. Category:Quality Week Issues that should be considered for quality week and removed Triage:NeedsMoreInfo WaitingForCustomer Applied when a NuGet triage person needs more info from the OP labels Dec 11, 2023
@Nigusu-Allehu Nigusu-Allehu self-assigned this Oct 2, 2024
@Nigusu-Allehu Nigusu-Allehu linked a pull request Feb 27, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nigusu-Allehu Nigusu-Allehu

Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore Priority:2 Issues for the current backlog. Product:VS.Client SeQuality Type:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log NU1105 error for badly specified framework NuGet/NuGet.Client
4 participants
@nkolev92 @jeffkl @v-luzh @Nigusu-Allehu