Move the vulnerable restore bar checks into the try part #5460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nigusu-Allehu
approved these changes
Oct 17, 2023
jeffkl
approved these changes
Oct 17, 2023
nkolev92
deleted the
dev-nkolev92-makevulnerabilityrestorebarchecksnullsafe
branch
nkolev92
added a commit
that referenced
this pull request
Oct 17, 2023
8 tasks
nkolev92
added a commit
that referenced
this pull request
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12939
Regression? Last working version:
Description
RestoreSummaries can be null when the restore spec validation fails.
An example is a project with an incorrect framework.
The vulnerable bar should've been in the try part anyways.
The finally part must never throw.
Note that this is an imperfect, partial fix. There's a follow up that'll need a longer fix in NuGet/Home#12943.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation