Fix timing units and update reward image count to 12#34
Merged
Conversation
…ard count - Fix levelUpStats() using newXp instead of this.xp for xpFactor calculation, causing stats to not scale with total accumulated XP - Fix missileDuration using seconds (0.35) instead of milliseconds (350), causing missile animations to complete instantly - Fix arcane beam trail life using seconds (0.2) instead of milliseconds (200), causing beam particles to vanish instantly - Fix numberOfRewardImages hardcoded to 5 instead of actual count of 12, preventing practice mode from showing all reward images - Update build script to also sync src/constants.ts reward count https://claude.ai/code/session_01JFbWn7GdZW5sDTWFXUkVqK
- Fix missile startDelay using seconds (0.07) instead of milliseconds (70), causing all 3 missiles to fire simultaneously on the first frame - Fix frost shard stagger by initializing progress to negative values (-i*50), enabling the existing delay check (progress <= 0) to create a sequential firing effect for the 5 shards https://claude.ai/code/session_01JFbWn7GdZW5sDTWFXUkVqK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes inconsistent timing units in the Wizard class, corrects a bug in the XP leveling calculation, and updates the reward image count from 5 to 12 across the codebase.
Key Changes
missileDurationfrom 0.35 to 350 andmagicTrailslife from 0.2 to 200 to use milliseconds consistently instead of secondslevelUpStats()to use cumulativethis.xpinstead of justnewXpfor calculating the XP factor, ensuring stats scale properly with total experiencenumberOfRewardImagesconstant from 5 to 12 insrc/constants.tsupdate-reward-count.tsto update both RPG constants and main constants files, with improved variable naming for clarityNotable Details
The timing unit changes align millisecond-based durations with the rest of the codebase's timing system. The XP calculation fix ensures that leveling progression is based on total accumulated experience rather than just the experience gained in the current level-up event.
https://claude.ai/code/session_01JFbWn7GdZW5sDTWFXUkVqK