FEAT: Install to the data-local directory if defined #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it's actually necessary
…with a path separator
…ta-local directory which doesn't already exist
…directory instead, and make LoadConfiguration recurse onto itself when config keys are encountered to handle layered openmw.cfg configurations
…dle configruation-defined configuration directories
…the end of a quoted path instead of the literal last double-quote
…d a child of the userdata directory
…keys using normal data directory parsing
…interpreted to be a data directory
magicaldave
force-pushed
the
feat/install-to-data-local
branch
from
32b7fda to
6a33c05
Compare
magicaldave
force-pushed
the
feat/install-to-data-local
branch
from
6a33c05 to
6f2f13f
Compare
…ta-local directory in order to correctly relativize paths
magicaldave
force-pushed
the
feat/install-to-data-local
branch
from
6f2f13f to
a1e8d1d
Compare
…d to append path separators manually and broke it because we tried
magicaldave
force-pushed
the
feat/install-to-data-local
branch
from
a4d9c4f to
13fec7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This depends on #51, but was implemented separatelly in case this aspect may be considered controversial.
If a user's configuration defines a data-local directory, then that directory will always load last.
Some people like to put tool plugins here, including myself. You'll never lose file conflicts when doing this and it's quite convenient.
This behavior is totally opt-in and can generally only be used if the user explicitly sets the install directory to the literal openmw installation directory, OR if the user themselves defines a
data-localkey in some other higher-priority configuration file tes3merge is aware of.Most people will either not be running tes3merge in this way or, if an explicit install path is set, it'll probably be pointing at the default openmw.cfg. I guess maybe there is a vague chance people using OpenMW Player plugin might have data-local directories defined which they both don't know about and tes3merge uses, but if that's the case they're also not likely to have anything in them.
tl;dr this will mostly never happen if you don't want it to.