front: add mev_tip_skim label + description#27
Open
simonmorley wants to merge 1 commit into
Open
Conversation
Render the new Solana mev_tip_skim event type with a delegator-facing
label ("Withheld MEV tips from delegators. Skim detected.") and a
detailed description of the closed-epoch Kobe-vs-merkle shortfall
detection.
Pairs with slasher-api PR #31 and the worker-side detector that
shipped in PR #34.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new event type, mev_tip_skim, to track and describe instances where MEV tips distributed to Solana delegators fall short of expected values. The changes include updates to the EventType API type and the addition of corresponding labels and descriptions in the constants file. Feedback was provided to improve the clarity of the event description by replacing internal jargon with more descriptive language and correcting the capitalization of 'Merkle'.
| vanilla_solana: 'Validator is running the stock Agave client rather than jito-solana, which means they are forfeiting MEV tip revenue that could otherwise flow to their delegators. For validators with meaningful stake this is a direct cost to delegators that does not show up in the advertised commission.', | ||
| jito_opted_out: 'Validator just switched from jito-solana to the stock Agave client, meaning MEV tip revenue that would have flowed to delegators is now being forfeited. A deliberate change, not a technical issue — worth understanding why.', | ||
| jito_opted_in: 'Validator resumed running jito-solana after a prior opt-out. MEV tip revenue flows to delegators again.', | ||
| mev_tip_skim: 'For a closed Solana epoch, the MEV tips actually distributed to this validator\'s delegators fell materially short of the expected staker share — computed as Jito MEV revenue minus the validator\'s stated commission. The Kobe data says one number; the on-chain merkle distribution says a smaller one. Both the percentage shortfall and absolute SOL gap exceeded conservative thresholds before this event was raised.', |
There was a problem hiding this comment.
The term Kobe appears to be internal jargon and might be confusing for public users. Consider using a more descriptive term like expected revenue data. Additionally, Merkle should be capitalized as it is a proper noun.
Suggested change
| mev_tip_skim: 'For a closed Solana epoch, the MEV tips actually distributed to this validator\'s delegators fell materially short of the expected staker share — computed as Jito MEV revenue minus the validator\'s stated commission. The Kobe data says one number; the on-chain merkle distribution says a smaller one. Both the percentage shortfall and absolute SOL gap exceeded conservative thresholds before this event was raised.', | |
| mev_tip_skim: 'For a closed Solana epoch, the MEV tips actually distributed to this validator\'s delegators fell materially short of the expected staker share — computed as Jito MEV revenue minus the validator\'s stated commission. The expected revenue data says one number; the on-chain Merkle distribution says a smaller one. Both the percentage shortfall and absolute SOL gap exceeded conservative thresholds before this event was raised.', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mev_tip_skimto theEventTypeunion and renders a delegator-facing label + Kobe-aware description on the public feedTest plan
npm run buildpasses (zero TS errors)