-
Notifications
You must be signed in to change notification settings - Fork 10
Make Pull Requests run a build with tests #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
https://github.com/OASIS-learn-study/minecraft-storeys-maker/runs/4046170262 shows how Google Cloud Build reports status... that's for building our |
According to https://cloud.google.com/build/docs/automating-builds/build-repos-from-github (also https://cloud.google.com/build/docs/automating-builds/create-manage-triggers) this is trivial to set up - I've just done it! @edewit NB that PRs from us will "auto-build", whereas from from our future army of contributors (LOL) 'collaborator or owner must comment "/gcbrun" to invoke trigger'. Also worth noting is that this won't just |
@vorburger we used to have a CI build I think it was Travis |
Pending #265, this is basically done now; I'll close this issue to clean up (as there is nothing additional to do here, other than that PR). |
@edewit it would be neat if we had CI on PRs for this project (again? can't remember if we used to).
We could EITHER set up something like Travis CI or Circle CI, or... maybe the Google Cloud Build which we're anyway working on for #259 could also do this? I'll try.
The text was updated successfully, but these errors were encountered: