-
Notifications
You must be signed in to change notification settings - Fork 10
Remove -x test from ./gradlew build in Dockerfile #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
OK pretty neat a link to https://github.com/OASIS-learn-study/minecraft-storeys-maker/pull/265/checks?check_run_id=4046656424 automagically just appeared on this PR. I've also just created a "branch protection rule" on https://github.com/OASIS-learn-study/minecraft-storeys-maker/settings/branches which means we can't push to the |
yeah that is pretty good integration, cool waiting for the build to finish |
Hm, we're probably not quite ready for this just yet, there are test failures we'll have to fix before merging this:
|
c7d838a
to
a7a5c3e
Compare
I've done this as part of #291. |
a7a5c3e
to
f040981
Compare
see #263 for full background why
This is the 1st PR which should automatically get CI built (on Google Cloud Build) - not sure how it will reflect on the GitHub UI...