Skip to content

Remove -x test from ./gradlew build in Dockerfile #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

vorburger
Copy link
Member

see #263 for full background why

This is the 1st PR which should automatically get CI built (on Google Cloud Build) - not sure how it will reflect on the GitHub UI...

@vorburger
Copy link
Member Author

This is the 1st PR which should automatically get CI built (on Google Cloud Build) - not sure how it will reflect on the GitHub UI...

OK pretty neat a link to https://github.com/OASIS-learn-study/minecraft-storeys-maker/pull/265/checks?check_run_id=4046656424 automagically just appeared on this PR.

I've also just created a "branch protection rule" on https://github.com/OASIS-learn-study/minecraft-storeys-maker/settings/branches which means we can't push to the develop branch directly anymore, and have to have passing builds - @edewit hope OK for you? Can I let you merge this when the buid passed?

@vorburger vorburger requested a review from edewit October 29, 2021 12:55
@edewit
Copy link
Member

edewit commented Oct 29, 2021

yeah that is pretty good integration, cool waiting for the build to finish

@vorburger
Copy link
Member Author

Hm, we're probably not quite ready for this just yet, there are test failures we'll have to fix before merging this:

ch.vorburger.minecraft.storeys.web.SeleniumTest > classMethod FAILED
    org.openqa.selenium.WebDriverException: Timed out waiting for driver server to start.
    Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:17:03'
    System info: host: 'cfd034f211cc', ip: '172.17.0.3', os.name: 'Linux', os.arch: 'amd64', os.version: '5.4.0-1052-gcp', java.version: '1.8.0_312'
    Driver info: driver.version: ChromeDriver
        at org.openqa.selenium.remote.service.DriverService.waitUntilAvailable(DriverService.java:202)
        at org.openqa.selenium.remote.service.DriverService.start(DriverService.java:188)
        at org.openqa.selenium.remote.service.DriverCommandExecutor.execute(DriverCommandExecutor.java:79)
        at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:552)
        at org.openqa.selenium.remote.RemoteWebDriver.startSession(RemoteWebDriver.java:213)
        at org.openqa.selenium.remote.RemoteWebDriver.<init>(RemoteWebDriver.java:131)
        at org.openqa.selenium.chrome.ChromeDriver.<init>(ChromeDriver.java:181)
        at org.openqa.selenium.chrome.ChromeDriver.<init>(ChromeDriver.java:168)
        at org.openqa.selenium.chrome.ChromeDriver.<init>(ChromeDriver.java:157)
        at ch.vorburger.minecraft.storeys.web.SeleniumTest.startWebDriver(SeleniumTest.java:137)
        at ch.vorburger.minecraft.storeys.web.SeleniumTest.setupClass(SeleniumTest.java:93)

        Caused by:
        org.openqa.selenium.net.UrlChecker$TimeoutException: Timed out waiting for [http://localhost:26243/status] to be available after 20002 ms
            at org.openqa.selenium.net.UrlChecker.waitUntilAvailable(UrlChecker.java:100)
            at org.openqa.selenium.remote.service.DriverService.waitUntilAvailable(DriverService.java:197)
            ... 10 more

            Caused by:
            java.util.concurrent.TimeoutException
                at java.util.concurrent.FutureTask.get(FutureTask.java:205)
                at com.google.common.util.concurrent.SimpleTimeLimiter.callWithTimeout(SimpleTimeLimiter.java:156)
                at org.openqa.selenium.net.UrlChecker.waitUntilAvailable(UrlChecker.java:75)
                ... 11 more

ch.vorburger.minecraft.storeys.web.SeleniumTest > classMethod FAILED
    java.lang.NullPointerException
        at ch.vorburger.minecraft.storeys.web.SeleniumTest.tearDownClass(SeleniumTest.java:146)

@edewit edewit force-pushed the rm-x-test-Dockerfile branch from c7d838a to a7a5c3e Compare October 29, 2021 13:37
@vorburger
Copy link
Member Author

I've done this as part of #291.

@vorburger vorburger closed this Apr 2, 2022
@vorburger
Copy link
Member Author

I've done this as part of #291.

Erm, no I didn't, I thought I had but forgot to push and when I did it still failed as above, so this is not done in #291.

However, what if for now we just exclude the SeleniumTest but at least run everything else, that would be a start... I'll try that.

@vorburger vorburger reopened this Apr 2, 2022
@vorburger vorburger force-pushed the rm-x-test-Dockerfile branch from a7a5c3e to f040981 Compare April 2, 2022 16:26
@edewit edewit merged commit fe40906 into develop Apr 2, 2022
@edewit edewit deleted the rm-x-test-Dockerfile branch April 2, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants