[18.0][MIG] account_reconcile_restrict_partner_mismatch: Migration to 18.0 #741
Conversation
will squash |
…on some journals / Enable on company level In some cases, accounting users should be allowed to mix partners. This will be configured on account journal level. In order to not break standard behaviors, the restriction feature should be enabled by a configuration parameter on company level. A new configuration parameter has been added.
…tions / tests improvements As accounting entries should be posted before reconciliation, test correct exceptions. Improvement to use BaseCommon class in tests
As the super() does not return 'True', if no self is defined, return the super() method
LucasTran380381
force-pushed
the
18.0-mig-account_reconcile_restrict_partner_mismatch
branch
from
c273d87 to
0a6b4b6
Compare
| in ("asset_receivable", "liability_payable") | ||
| ) | ||
|
|
||
| def reconcile(self): |
There was a problem hiding this comment.
This function is not called when using this module with OEE. You should instead hook on account.move.line._reconcile_plan
There was a problem hiding this comment.
I changed method _reconcile_plan to fixed with Odoo EE
LucasTran380381
force-pushed
the
18.0-mig-account_reconcile_restrict_partner_mismatch
branch
from
0a6b4b6 to
9ed55f8
Compare
There was a problem hiding this comment.
Would be good to improve the test because having them green is obviously wrong right now.
Also, functionally speaking, I don't see a test validating two move lines with same partner getting reconciled, and it would be great to use different journals. (that is not strictly required for the mig but maybe add a comment in the roadmap)
| if self: | ||
| partners = set() | ||
| for line in self: |
There was a problem hiding this comment.
_reconcile_plan is an api.model function, you should loop over the reconciliation_plan var instead (cf docstring to know how it must be structured)
There was a problem hiding this comment.
improved test-case and loop over reconciliation_plan as suggested
LucasTran380381
force-pushed
the
18.0-mig-account_reconcile_restrict_partner_mismatch
branch
from
9ed55f8 to
4ee453e
Compare
[Fix] fix adapt ui for odoo18 [Fix] Fix res_config_view for odoo18 [Fix] fix review point
LucasTran380381
force-pushed
the
18.0-mig-account_reconcile_restrict_partner_mismatch
branch
from
4ee453e to
7f64e9e
Compare
|
This PR has the |
Base on #596